manager/orion-visor
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

review code.

Browse Source
This commit is contained in:
lijiahang
2023-09-14 17:26:24 +08:00
parent a210fb93fd
commit 1665820459
17 changed files with 31 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
orion-ops-module-infra/orion-ops-module-infra-service/src/main/java/com/orion/ops/module/infra/controller/SystemRoleController.java
View File

@@ -5,7 +5,7 @@ import com.orion.ops.framework.common.annotation.IgnoreLog;
import com.orion.ops.framework.common.annotation.RestWrapper;
import com.orion.ops.framework.common.constant.IgnoreLogMode;
import com.orion.ops.framework.common.valid.group.Page;
import com.orion.ops.module.infra.entity.request.menu.SystemRoleBindMenuRequest;
import com.orion.ops.module.infra.entity.request.menu.SystemRoleGrantMenuRequest;
import com.orion.ops.module.infra.entity.request.role.SystemRoleCreateRequest;
import com.orion.ops.module.infra.entity.request.role.SystemRoleQueryRequest;
import com.orion.ops.module.infra.entity.request.role.SystemRoleStatusRequest;
@@ -107,11 +107,11 @@ public class SystemRoleController {
return systemRoleService.deleteSystemRoleById(id);
}
@PutMapping("/bind")
@PutMapping("/grant-menu")
@Operation(summary = "绑定角色菜单")
@PreAuthorize("@ss.hasPermission('infra:system-role:bind-menu')")
public Integer bindRoleMenu(@RequestBody SystemRoleBindMenuRequest request) {
return systemRoleMenuService.bindRoleMenu(request);
@PreAuthorize("@ss.hasPermission('infra:system-role:grant-menu')")
public Integer grantRoleMenu(@RequestBody SystemRoleGrantMenuRequest request) {
return systemRoleMenuService.grantRoleMenu(request);
}
}

6
orion-ops-module-infra/orion-ops-module-infra-service/src/main/java/com/orion/ops/module/infra/controller/SystemUserController.java
View File

@@ -68,9 +68,9 @@ public class SystemUserController {
return systemUserService.updateUserStatus(request);
}
@PutMapping("/update-role")
@Operation(summary = "修改用户角色")
@PreAuthorize("@ss.hasPermission('infra:system-user:update-role')")
@PutMapping("/grant-role")
@Operation(summary = "分配用户角色")
@PreAuthorize("@ss.hasPermission('infra:system-user:grant-role')")
public Integer updateUserRole(@Validated @RequestBody SystemUserUpdateRoleRequest request) {
if (Lists.isEmpty(request.getRoleIdList())) {
// 删除用户角色

10
orion-ops-module-infra/orion-ops-module-infra-service/src/main/java/com/orion/ops/module/infra/controller/TagController.java
View File

@@ -10,7 +10,6 @@ import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.Parameter;
import io.swagger.v3.oas.annotations.tags.Tag;
import lombok.extern.slf4j.Slf4j;
import org.springframework.security.access.prepost.PreAuthorize;
import org.springframework.validation.annotation.Validated;
import org.springframework.web.bind.annotation.*;
@@ -37,25 +36,22 @@ public class TagController {
private TagService tagService;
@PostMapping("/create")
@Operation(summary = "创建标签枚举")
@PreAuthorize("@ss.hasPermission('infra:tag:create')")
@Operation(summary = "创建标签")
public Long createTag(@Validated @RequestBody TagCreateRequest request) {
return tagService.createTag(request);
}
@IgnoreLog(IgnoreLogMode.RET)
@GetMapping("/list")
@Operation(summary = "查询标签枚举")
@Operation(summary = "查询标签")
@Parameter(name = "type", description = "type", required = true)
@PreAuthorize("@ss.hasPermission('infra:tag:query')")
public List<TagVO> getTagListAll(@RequestParam("type") String type) {
return tagService.getTagList(type);
}
@DeleteMapping("/delete")
@Operation(summary = "通过 id 删除标签枚举")
@Operation(summary = "通过 id 删除标签")
@Parameter(name = "id", description = "id", required = true)
@PreAuthorize("@ss.hasPermission('infra:tag:delete')")
public Integer deleteTag(@RequestParam("id") Long id) {
return tagService.deleteTagById(id);
}

1
orion-ops-module-infra/orion-ops-module-infra-service/src/main/java/com/orion/ops/module/infra/convert/TagRelConvert.java
View File

@@ -24,6 +24,7 @@ public interface TagRelConvert {
TagRelDO to(TagRelQueryRequest request);
@Mapping(target = "name", source = "tagName")
@Mapping(target = "id", source = "tagId")
TagCacheDTO toCache(TagRelDO domain);
List<TagCacheDTO> toCacheList(List<TagRelDO> list);

4
orion-ops-module-infra/orion-ops-module-infra-service/src/main/java/com/orion/ops/module/infra/entity/request/menu/SystemRoleBindMenuRequest.java → orion-ops-module-infra/orion-ops-module-infra-service/src/main/java/com/orion/ops/module/infra/entity/request/menu/SystemRoleGrantMenuRequest.java
View File

@@ -22,8 +22,8 @@ import java.util.List;
@Builder
@NoArgsConstructor
@AllArgsConstructor
@Schema(name = "SystemRoleBindMenuRequest", description = "角色 绑定菜单请求对象")
public class SystemRoleBindMenuRequest implements Serializable {
@Schema(name = "SystemRoleGrantMenuRequest", description = "角色 绑定菜单请求对象")
public class SystemRoleGrantMenuRequest implements Serializable {
@NotNull
@Schema(description = "roleId")

6
orion-ops-module-infra/orion-ops-module-infra-service/src/main/java/com/orion/ops/module/infra/service/SystemRoleMenuService.java
View File

@@ -1,6 +1,6 @@
package com.orion.ops.module.infra.service;
import com.orion.ops.module.infra.entity.request.menu.SystemRoleBindMenuRequest;
import com.orion.ops.module.infra.entity.request.menu.SystemRoleGrantMenuRequest;
import java.util.List;
@@ -14,12 +14,12 @@ import java.util.List;
public interface SystemRoleMenuService {
/**
* 绑定角色菜单
* 分配角色菜单
*
* @param request request
* @return effect
*/
Integer bindRoleMenu(SystemRoleBindMenuRequest request);
Integer grantRoleMenu(SystemRoleGrantMenuRequest request);
/**
* 获取角色菜单 id

2
orion-ops-module-infra/orion-ops-module-infra-service/src/main/java/com/orion/ops/module/infra/service/impl/FavoriteServiceImpl.java
View File

@@ -68,7 +68,7 @@ public class FavoriteServiceImpl implements FavoriteService {
int effect = favoriteDAO.deleteFavorite(type, userId, relId);
// 删除缓存
String key = FavoriteCacheKeyDefine.FAVORITE.format(type, userId);
redisTemplate.opsForList().remove(key, 1, relId);
redisTemplate.opsForList().remove(key, 1, relId.toString());
return effect;
}

4
orion-ops-module-infra/orion-ops-module-infra-service/src/main/java/com/orion/ops/module/infra/service/impl/SystemRoleMenuServiceImpl.java
View File

@@ -14,7 +14,7 @@ import com.orion.ops.module.infra.entity.domain.SystemMenuDO;
import com.orion.ops.module.infra.entity.domain.SystemRoleDO;
import com.orion.ops.module.infra.entity.domain.SystemRoleMenuDO;
import com.orion.ops.module.infra.entity.dto.SystemMenuCacheDTO;
import com.orion.ops.module.infra.entity.request.menu.SystemRoleBindMenuRequest;
import com.orion.ops.module.infra.entity.request.menu.SystemRoleGrantMenuRequest;
import com.orion.ops.module.infra.service.PermissionService;
import com.orion.ops.module.infra.service.SystemRoleMenuService;
import lombok.extern.slf4j.Slf4j;
@@ -52,7 +52,7 @@ public class SystemRoleMenuServiceImpl implements SystemRoleMenuService {
@Override
@Transactional(rollbackFor = Exception.class)
public Integer bindRoleMenu(SystemRoleBindMenuRequest request) {
public Integer grantRoleMenu(SystemRoleGrantMenuRequest request) {
Long roleId = request.getRoleId();
List<Long> menuIdList = request.getMenuIdList();
// 检查角色是否存在