代码优化

This commit is contained in:
thinkgem
2024-07-26 11:04:08 +08:00
parent 35a32ce799
commit 91b6344479
11 changed files with 29 additions and 40 deletions

View File

@@ -12,7 +12,6 @@ import com.jeesite.common.lang.StringUtils;
import com.jeesite.common.web.BaseController;
import com.jeesite.modules.biz.entity.BizCategory;
import com.jeesite.modules.biz.service.BizCategoryService;
import com.jeesite.modules.sys.utils.UserUtils;
import io.swagger.v3.oas.annotations.tags.Tag;
import org.apache.shiro.authz.annotation.RequiresPermissions;
import org.springframework.beans.factory.annotation.Autowired;
@@ -236,7 +235,7 @@ public class BizCategoryController extends BaseController {
@RequestMapping(value = "fixTreeData")
@ResponseBody
public String fixTreeData(BizCategory bizCategory){
if (!UserUtils.getUser().isAdmin()){
if (!bizCategory.currentUser().isAdmin()){
return renderResult(Global.FALSE, "操作失败,只有管理员才能进行修复!");
}
bizCategoryService.fixTreeData();

View File

@@ -14,7 +14,6 @@ import com.jeesite.common.web.BaseController;
import com.jeesite.modules.sys.entity.Area;
import com.jeesite.modules.sys.service.AreaService;
import com.jeesite.modules.sys.utils.AreaUtils;
import com.jeesite.modules.sys.utils.UserUtils;
import io.swagger.v3.oas.annotations.tags.Tag;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
@@ -257,8 +256,8 @@ public class AreaController extends BaseController {
@RequiresPermissions("sys:area:edit")
@RequestMapping(value = "fixTreeData")
@ResponseBody
public String fixTreeData(){
if (!UserUtils.getUser().isAdmin()){
public String fixTreeData(Area area){
if (!area.currentUser().isAdmin()){
return renderResult(Global.FALSE, text("操作失败,只有管理员才能进行修复!"));
}
areaService.fixTreeData();

View File

@@ -14,8 +14,8 @@ import com.jeesite.modules.sys.entity.Company;
import com.jeesite.modules.sys.entity.Office;
import com.jeesite.modules.sys.service.CompanyService;
import com.jeesite.modules.sys.service.OfficeService;
import com.jeesite.modules.sys.utils.UserUtils;
import io.swagger.v3.oas.annotations.tags.Tag;
import jakarta.servlet.http.HttpServletRequest;
import org.apache.shiro.authz.annotation.RequiresPermissions;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
@@ -27,7 +27,6 @@ import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.ResponseBody;
import jakarta.servlet.http.HttpServletRequest;
import java.util.List;
import java.util.Map;
@@ -271,8 +270,8 @@ public class CompanyController extends BaseController {
@RequiresPermissions("sys:company:edit")
@RequestMapping(value = "fixTreeData")
@ResponseBody
public String fixTreeData() {
if (!UserUtils.getUser().isAdmin()){
public String fixTreeData(Company company) {
if (!company.currentUser().isAdmin()){
return renderResult(Global.FALSE, text("操作失败,只有管理员才能进行修复!"));
}
companyService.fixTreeData();

View File

@@ -15,7 +15,6 @@ import com.jeesite.modules.sys.entity.DictType;
import com.jeesite.modules.sys.service.DictDataService;
import com.jeesite.modules.sys.service.DictTypeService;
import com.jeesite.modules.sys.utils.DictUtils;
import com.jeesite.modules.sys.utils.UserUtils;
import io.swagger.v3.oas.annotations.Hidden;
import jakarta.servlet.http.HttpServletRequest;
import org.apache.shiro.authz.annotation.RequiresPermissions;
@@ -286,8 +285,8 @@ public class DictDataController extends BaseController {
@RequiresPermissions("sys:dictData:edit")
@RequestMapping(value = "fixTreeData")
@ResponseBody
public String fixTreeData(){
if (!UserUtils.getUser().isAdmin()){
public String fixTreeData(DictData dictData){
if (!dictData.currentUser().isAdmin()){
return renderResult(Global.FALSE, text("操作失败,只有管理员才能进行修复!"));
}
dictDataService.fixTreeData();

View File

@@ -271,8 +271,8 @@ public class MenuController extends BaseController {
@RequiresPermissions("sys:menu:edit")
@RequestMapping(value = "fixTreeData")
@ResponseBody
public String fixTreeData(){
if (!UserUtils.getUser().isAdmin()){
public String fixTreeData(Menu menu){
if (!menu.currentUser().isAdmin()){
return renderResult(Global.FALSE, text("操作失败,只有管理员才能进行修复!"));
}
menuService.fixTreeData();

View File

@@ -15,7 +15,6 @@ import com.jeesite.common.utils.excel.annotation.ExcelField.Type;
import com.jeesite.common.web.BaseController;
import com.jeesite.modules.sys.entity.Office;
import com.jeesite.modules.sys.service.OfficeService;
import com.jeesite.modules.sys.utils.UserUtils;
import com.jeesite.modules.sys.web.user.EmpUserController;
import io.swagger.v3.oas.annotations.tags.Tag;
import jakarta.servlet.http.HttpServletResponse;
@@ -352,8 +351,8 @@ public class OfficeController extends BaseController {
@RequiresPermissions("sys:office:edit")
@RequestMapping(value = "fixTreeData")
@ResponseBody
public String fixTreeData() {
if (!UserUtils.getUser().isAdmin()){
public String fixTreeData(Office office) {
if (!office.currentUser().isAdmin()){
return renderResult(Global.FALSE, text("操作失败,只有管理员才能进行修复!"));
}
officeService.fixTreeData();

View File

@@ -132,7 +132,7 @@ public class CorpAdminController extends BaseController {
User where = new User();
where.setCorpCode_(user.getCorpCode_());
List<User> list = userService.findCorpList(where);
if (list.size() > 0){
if (!list.isEmpty()){
// 新增租户,如果已存在,则不能保存
if ("addCorp".equals(op)){
return renderResult(Global.FALSE, text("保存租户失败,租户代码已存在"));
@@ -151,7 +151,7 @@ public class CorpAdminController extends BaseController {
userService.save(user);
userService.saveAuth(user);
// 如果修改的是当前用户,则清除当前用户缓存
if (user.getUserCode().equals(UserUtils.getUser().getUserCode())) {
if (user.getUserCode().equals(user.currentUser().getUserCode())) {
UserUtils.clearCache();
}
return renderResult(Global.TRUE, text("保存管理员''{0}''成功", user.getLoginCode()));
@@ -275,7 +275,7 @@ public class CorpAdminController extends BaseController {
where.setCorpCode_(corpCode);
where.setPage(new Page<>(1, 1, -1));
List<User> list = userService.findCorpList(where);
if (list.size() > 0){
if (!list.isEmpty()){
User user = list.get(0);
Session session = UserUtils.getSession();
session.setAttribute("corpCode", user.getCorpCode_());

View File

@@ -35,7 +35,6 @@ import com.jeesite.common.collect.ListUtils;
import com.jeesite.common.collect.MapUtils;
import com.jeesite.common.lang.StringUtils;
import com.jeesite.common.idgen.IdGen;
import com.jeesite.modules.sys.utils.UserUtils;
<% }else{ %>
import com.jeesite.common.entity.Page;
<% } %>
@@ -368,7 +367,7 @@ public class ${ClassName}Controller extends BaseController {
@RequestMapping(value = "fixTreeData")
@ResponseBody
public String fixTreeData(${ClassName} ${className}){
if (!UserUtils.getUser().isAdmin()){
if (!${className}.currentUser().isAdmin()){
return renderResult(Global.FALSE, "操作失败,只有管理员才能进行修复!");
}
${className}Service.fixTreeData();

View File

@@ -35,7 +35,6 @@ import com.jeesite.common.collect.ListUtils;
import com.jeesite.common.collect.MapUtils;
import com.jeesite.common.lang.StringUtils;
import com.jeesite.common.idgen.IdGen;
import com.jeesite.modules.sys.utils.UserUtils;
<% }else{ %>
import com.jeesite.common.entity.Page;
<% } %>
@@ -370,7 +369,7 @@ public class ${ClassName}Controller extends BaseController {
@RequestMapping(value = "fixTreeData")
@ResponseBody
public String fixTreeData(${ClassName} ${className}){
if (!UserUtils.getUser().isAdmin()){
if (!${className}.currentUser().isAdmin()){
return renderResult(Global.FALSE, "操作失败,只有管理员才能进行修复!");
}
${className}Service.fixTreeData();